Skip to content

vimPlugins.nvim-treesitter-textobjects: 0-unstable-2025-10-31 -> 0-unstable-2025-12-27#475611

Merged
minijackson merged 1 commit intoNixOS:masterfrom
DarkKirb:nvim-treesitter-textobjects-2025-12-27
Jan 5, 2026
Merged

vimPlugins.nvim-treesitter-textobjects: 0-unstable-2025-10-31 -> 0-unstable-2025-12-27#475611
minijackson merged 1 commit intoNixOS:masterfrom
DarkKirb:nvim-treesitter-textobjects-2025-12-27

Conversation

@DarkKirb
Copy link
Contributor

@DarkKirb DarkKirb commented Dec 31, 2025 •
edited
Loading

Stopped building after the master → main migration

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: vim Advanced text editor labels Dec 31, 2025
GaetanLepage
GaetanLepage reviewed Dec 31, 2025
View reviewed changes
@DarkKirb DarkKirb force-pushed the nvim-treesitter-textobjects-2025-12-27 branch from e223994 to 94617c5 Compare December 31, 2025 14:34
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Dec 31, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 475611 --package vimPlugins.nvim-treesitter-textobjects
Commit: 94617c5739d57db0c0836d3f3ff611f54d655941

x86_64-linux

✅ 1 package built:
  • vimPlugins.nvim-treesitter-textobjects

aarch64-linux

✅ 1 package built:
  • vimPlugins.nvim-treesitter-textobjects

x86_64-darwin

✅ 1 package built:
  • vimPlugins.nvim-treesitter-textobjects

aarch64-darwin

✅ 1 package built:
  • vimPlugins.nvim-treesitter-textobjects

PerchunPak
PerchunPak reviewed Dec 31, 2025
View reviewed changes
pkgs/applications/editors/vim/plugins/vim-plugin-names
https://github.com/nvim-treesitter/nvim-treesitter-refactor/,,
https://github.com/PaterJason/nvim-treesitter-sexp/,HEAD,
https://github.com/nvim-treesitter/nvim-treesitter-textobjects/,,
https://github.com/nvim-treesitter/nvim-treesitter-textobjects/,main,
Copy link
Member

@PerchunPak PerchunPak Dec 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do vim-plugins-updater add 'https://github.com/nvim-treesitter/nvim-treesitter-textobjects as nvim-treesitter-textobjects-legacy' please?

Copy link
Contributor Author

@DarkKirb DarkKirb Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don’t think it is needed as its dependency nvim-treesitter-legacy doesn’t exist

Copy link
Member

@PerchunPak PerchunPak Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we will merge #472119 in at most hours

Copy link
Member

@mrcjkb mrcjkb Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for the legacy version? I've been using the main version with nvim-treesitter master and it works fine.

Copy link
Member

@PerchunPak PerchunPak Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving people some time to migrate is good nonetheless

Copy link
Contributor Author

@DarkKirb DarkKirb Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the pr is still not merged yet, i think it is wiser to merge this pr as is and add the -legacy version to the -legacy plugin pr

Copy link
Member

@PerchunPak PerchunPak Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a follow-up PR after #472119

@wadeduvall
Copy link

wadeduvall commented Jan 4, 2026

Here's an overlay if you want to use the new plugin:

  textobject-fix = final: prev: {
    vimPlugins =
      prev.vimPlugins
      // {
        nvim-treesitter-textobjects = prev.vimUtils.buildVimPlugin {
          pname = "nvim-treesitter-textobjects";
          version = "0-unstable-2025-12-27";
          src = prev.fetchFromGitHub {
            owner = "nvim-treesitter";
            repo = "nvim-treesitter-textobjects";
            rev = "ecd03f5811eb5c66d2fa420b79121b866feecd82";
            hash = "sha256-mMxCAkrGqTstEgaf/vwQMEF7D8swH3oyUJtaxuXzpcs=";
          };
          meta.homepage = "https://github.com/nvim-treesitter/nvim-treesitter-textobjects/";
          meta.hydraPlatforms = [];
        };
      };
  };

minijackson
minijackson approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR good to merge, then?

@DarkKirb
Copy link
Contributor Author

DarkKirb commented Jan 5, 2026 via email

@minijackson minijackson added this pull request to the merge queue Jan 5, 2026
Merged via the queue into NixOS:master with commit 5377fbe Jan 5, 2026
39 of 41 checks passed
This was referenced Jan 6, 2026
Closed
Closed
@jiriks74
Copy link
Contributor

jiriks74 commented Jan 8, 2026

I just updated and it seems that something has broken after these modifications:

error: You cannot include two different versions of nvim-treesitter, perhaps you included a legacy plugin together with a new one?

@vendion vendion mentioned this pull request Jan 20, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage left review comments

@minijackson minijackson minijackson approved these changes

@khaneliman khaneliman Awaiting requested review from khaneliman

@mrcjkb mrcjkb Awaiting requested review from mrcjkb

+1 more reviewer

@PerchunPak PerchunPak PerchunPak left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DarkKirb @GaetanLepage @wadeduvall @jiriks74 @minijackson @mrcjkb @PerchunPak